fix(tasks): green the full suite — task-row rename test awaits F-254 microtask#119
Closed
th3-br41n wants to merge 1 commit into
Closed
fix(tasks): green the full suite — task-row rename test awaits F-254 microtask#119th3-br41n wants to merge 1 commit into
th3-br41n wants to merge 1 commit into
Conversation
The F-254 fix deferred beginInlineEdit's onCommit via queueMicrotask, but task-row.test.ts still asserted onRenameTask synchronously — missed because the local verify run only exercised the three edited suites, not the full Tasks suite (the ubuntu full-suite job caught it). Await a microtask before the assertion. Full apps/tasks suite green (450). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Contributor
Author
|
Folded the fix directly into the release PR #118 so it's self-contained and greens main on merge — superseded. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the ubuntu full-suite failure that landed with #117. The F-254 fix deferred
beginInlineEdit'sonCommitviaqueueMicrotask; I updated the three suites I edited (inline-edit, board-view, sidebar) but missedtask-row.test.ts— which also renames throughbeginInlineEditand assertedonRenameTasksynchronously. Localverifyonly ran the edited suites; the ubuntu full-suite job caught it (exactly the subset-gap the job exists for).Fix: await a microtask before the assertion. Full
apps/taskssuite green (450).beginInlineEdit/board/sidebar are Tasks-local, so the blast radius is fully contained.🤖 Generated with Claude Code