feat(automations): computeInitialFire + OnMissedPolicy — missed-remin…#130
Merged
Conversation
…der catch-up core
The pure scheduling core for 0.3.1 missed-reminder catch-up. A one-shot that
comes due while the app is CLOSED is currently dropped (computeNextFire strict
>after → dormant). Adds:
- OnMissedPolicy { Skip (default) | FireOnce } on TimeTriggerConfig.
- computeInitialFire(config, now, lastRun): arms a FireOnce one-shot whose
instant fell in (lastRun, now] at that past instant, so dueFires catches it
once; Skip keeps the pre-0.3.1 dormant behaviour. Exactly-once falls out of
the lastRun watermark (advanced past the instant after firing).
Pure + additive (no caller uses it yet). +6 tests. Automations suite 221 green.
Remaining wiring (next slice): SchedulerService lastRun field + scheduler_meta
persistence (registry.db migration) + item-alerts '> lastRun' filter + onMissed
on its configs + wiring pass-through; then /security-review (scheduler + new
persistence).
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…der catch-up core
The pure scheduling core for 0.3.1 missed-reminder catch-up. A one-shot that comes due while the app is CLOSED is currently dropped (computeNextFire strict
Pure + additive (no caller uses it yet). +6 tests. Automations suite 221 green.
Remaining wiring (next slice): SchedulerService lastRun field + scheduler_meta persistence (registry.db migration) + item-alerts '> lastRun' filter + onMissed on its configs + wiring pass-through; then /security-review (scheduler + new persistence).