feat(browser): in-browser "Trust this site" affordance (Browser-8)#147
Merged
Conversation
Browser-8 shipped only the Settings → Privacy trusted-sites management; there was no in-browser way to trust the current site. Add the capability-gated broker twin so the sandboxed Browser (holds `web.browse`) reaches the same per-vault trust store, plus the chrome affordance: - sdk-types: `WebViewMethod.SetSiteTrust` / `IsSiteTrusted` + request union + `WebViewClient.setSiteTrust`/`isSiteTrusted`. - web-view-service: the two handler cases + `setSiteTrust`/`isSiteTrusted` options. - main/index.ts: wired to `webPrivacy.trust.set` / `.isTrusted` (the exact store the Settings panel uses). - SDK webViewProxy: the two client methods over the broker. - Browser app: a "Trust this site" / "Untrust this site" toggle in the ⋯ menu (only for a real web origin), reflecting the live trust state (queried on tab change) and reloading on toggle so the relaxed cookie/blocklist policy applies. Full typecheck (packages + 12 apps) + 23 browser tests + web-view-service 22 + browser build + lint clean. Behavioural check is real-shell. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Browser-8 shipped only the Settings → Privacy trusted-sites management; there was no in-browser way to trust the current site. Add the capability-gated broker twin so the sandboxed Browser (holds
web.browse) reaches the same per-vault trust store, plus the chrome affordance:WebViewMethod.SetSiteTrust/IsSiteTrusted+ request union +WebViewClient.setSiteTrust/isSiteTrusted.setSiteTrust/isSiteTrustedoptions.webPrivacy.trust.set/.isTrusted(the exact store the Settings panel uses).Full typecheck (packages + 12 apps) + 23 browser tests + web-view-service 22 + browser build + lint clean. Behavioural check is real-shell.