fix(update): show real app version + correct release feed owner#59
Merged
Conversation
The preload bridge hard-coded `version: "0.0.1"`, so Settings → General always displayed 0.0.1 regardless of the packaged build. Resolve the real version synchronously from the main process (`app.getVersion()`) via a new `app:get-version` sync IPC. Also fix a typo in the electron-builder publish config: the GitHub owner was `brainst0rm-os` (zero) instead of the real org `brainstorm-os`. It only resolved via GitHub's rename redirect — fragile for the auto-update feed. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Two small fixes to the in-app update / version surface.
1. Settings → General showed version
0.0.1The preload bridge hard-coded
version: "0.0.1"instead of reading the real packaged version, so the General tab always displayed0.0.1regardless of the actual build (currently 0.1.6). This also misled users into thinking they were far behind and "stuck", when they were actually on the latest published release.Fix: preload resolves the version synchronously from the main process via a new
app:get-versionsync IPC that returnsapp.getVersion().2. Release-feed publish owner typo
electron-builderpublish.ownerwasbrainst0rm-os(with a zero) instead of the real orgbrainstorm-os. It currently only resolves via GitHub's org-rename redirect — fragile for the auto-update feed.Fix: corrected to
brainstorm-os.Why the updater "didn't download"
With the version display fixed, the prior confusion is resolved: an app on the latest published release correctly finds nothing to download. (Note: a check only detects; the in-app download is a deliberate second step via the Download button once an update is
Available.)Test
tsc --noEmitclean on packages (verified on the identical change).app.getVersion().🤖 Generated with Claude Code