test(flake): fix oauth-redirect reject-race that failed green CI runs#72
Merged
Conversation
…aked servers The recurring CI flake — 'Vitest caught N unhandled errors' failing otherwise-green runs — had two roots this session. entity-icon-read (booting the whole app past teardown) was fixed in #67; this fixes the other: - oauth-redirect.test.ts 'state mismatch': codePromise rejected DURING the await hit() that triggers it, but the .rejects assertion was attached on the NEXT line — leaving a microtask window where the rejection was unhandled, which vitest catches and fails the run. Attach the assertion before the trigger. - Also track every loopback capture and close() it in afterEach so a server from a non-terminal path (mismatch / early redirect) can't outlive its test and emit a late error event. Verified: oauth suite 3× clean (no Errors); full suite 2× clean of unhandled errors (14084 passed). A grep for the reject-var-then-.rejects race pattern across all test files finds only this file — no other test carries it. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The flake
The 'Vitest caught N unhandled errors' failure that intermittently failed otherwise-green CI runs (I re-ran the failed job on three PRs this session) had two roots.
entity-icon-read(booting the whole database app past jsdom teardown) was fixed in #67. This fixes the other:oauth-redirect.test.ts— 'state mismatch':codePromiserejected during theawait hit()that triggers it, but.rejectswas attached on the next line — a microtask window where the rejection is unhandled. Vitest catches that and fails the run. Fix: attach the assertion before the trigger. Also track each loopbackcaptureandclose()it inafterEachso a server from a non-terminal path can't outlive its test.Confidence it's comprehensive
Errors), full suite 2× clean of unhandled errors (14084 passed each).*.test.ts(x)for the reject-var-then-.rejectsrace shape — only this file carried it.(Note: the leak class has per-test root causes — a boot-leak here, a reject-race there — so there's no single systemic fix; these two were the observed CI offenders.)
🤖 Generated with Claude Code