fix(welcome): visible icon chips, no stuck focus ring, scrollable recent list#80
Merged
Conversation
…cus ring, make long recent list scroll - --color-surface-raised was referenced in 9 renderer rules (welcome tile chips, template-card chips, settings panels) but never defined in any theme, so those surfaces rendered transparent — the welcome tiles' icon chips were invisible next to the accent-tinted primary chip. Add surface.raised to the token shape, all 12 themes, and the canonical token-name snapshot. - Remove the welcome tile's local :focus-visible ring: popover/dialog close restores focus programmatically and Chromium marks it :focus-visible, lighting a stuck accent ring after plain mouse clicks. Deliberate Tab still gets the global kbnav themed ring. - Long recent-vault lists: cap the list at ~5 rows with in-place scroll, let the splash itself scroll on short windows (margin-auto centering so the top stays reachable), pin the drag-region title bar, and keep vault names on one line (path ellipsizes first). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Pre-existing working-tree change (from an earlier session) included so the tree is clean. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--color-surface-raisedtoken: it was referenced by 9 renderer rules (welcome tile chips, template-card chips, several Settings panels) but never defined in any theme, so those surfaces rendered transparent. Addedsurface.raisedto the token shape, all 12 themes, and theCANONICAL_TOKEN_NAMESsnapshot — the welcome tiles' icon chips now all read as matching 44px chips.:focus-visiblering. Folder-dialog / popover close restores focus programmatically and Chromium marks that restore:focus-visible, so the accent ring stuck after plain mouse clicks. Deliberate Tab still shows the global[data-kbnav]themed ring (WCAG 2.4.7 intact).Verification
outline: noneafter popover close, kbnav ring appears only after a real Tab, list scrolls in place.vitesttokens + welcome suites pass (31/31);check-css-tokenspasses (everyvar()resolves); biome clean.🤖 Generated with Claude Code