Experimental CAN support tested via Waveshare's esp32-s3-lcd-4.3-board - #117
Merged
Conversation
…with IO multiplexer and CAN support
jubeormk1
reviewed
Jul 26, 2026
jubeormk1
reviewed
Jul 26, 2026
jubeormk1
reviewed
Jul 26, 2026
jubeormk1
reviewed
Jul 26, 2026
jubeormk1
reviewed
Jul 26, 2026
jubeormk1
reviewed
Jul 26, 2026
jubeormk1
reviewed
Jul 26, 2026
jubeormk1
reviewed
Jul 26, 2026
jubeormk1
approved these changes
Jul 26, 2026
jubeormk1
left a comment
Collaborator
There was a problem hiding this comment.
I must say that it is interesting how this new interface has been added. It opens the use of many interfaces.
The last mile to get the final connection with the peripheral pins is complicated, getting the pins for SCA, SCL and the maps in toml are points that would be great to reimplement once there is a more straight forward way to obtain pins from an integer coming from a variable or config file.
… from platform and to the board level layer (via ssh-stamp-esp32-boards/build.rs)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
That is https://docs.waveshare.com/ESP32-S3-Touch-LCD-4.3 (thanks E for the donation!)
Implements CAN support over a SSH session (slcan format for now), that is:
And on the client side state
-sfor session (OBS: weird ordering of the-sandcanarguments, I know, but that's how SSH client works):