Isolate daemon sessions by coding-agent source - #40
Merged
Stephen Belanger (Qard) merged 3 commits intoSep 1, 2026
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3c6df13707
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "Codex (@codex) review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "Codex (@codex) address that feedback".
Stephen Belanger (Qard)
requested review from
Abhijeet Prasad (AbhiPrasad) and
Andrew Kent (realark)
September 1, 2026 16:44
Abhijeet Prasad (AbhiPrasad)
approved these changes
Sep 1, 2026
Stephen Belanger (Qard)
deleted the
fix/source-qualified-daemon-sessions
branch
September 1, 2026 17:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
A native session ID is only unique within a coding agent. The daemon previously used that ID alone for journals, locks, delivery keys, and deterministic span namespaces, so two agents reusing the same value could collide.
This PR makes the canonical agent source part of daemon session identity. It:
This is intentionally limited to source identity and daemon state isolation; it does not change translator checkpoint/finalization behavior, managed-run capture, transcript import, or package distribution.
Validation
cargo test --manifest-path bt-daemon/Cargo.toml --all-featurescargo clippy --manifest-path bt-daemon/Cargo.toml --all-targets --all-features -- -D warningscargo fmt --manifest-path bt-daemon/Cargo.toml -- --checkgit diff --checkThe full daemon suite passes, including 20 distributed-tracing tests and new coverage for same-ID cross-agent isolation, strict source rejection, and legacy journal migration. Real-agent tests remain ignored by the default suite because this slice changes daemon identity/recovery rather than agent adapters.