pretty cli output - #1090
Conversation
Eden Halperin (edenh)
commented
Nov 20, 2025
Eden Halperin (edenh)
commented
|
looks great. |
| "simple-git": "^3.21.0", | ||
| "slugify": "^1.6.6", | ||
| "source-map": "^0.7.4", | ||
| "terminal-link": "^5.0.0", |
There was a problem hiding this comment.
i'm not very knowledgable about js/ts/node deps, but if these have possibility of conflicting with customer's dependencies, we might not want to include them and either (a) reimplement the functionality or (b) copy their source into our tree, depending on how complicated they are. I imagine terminal-link isn't that complicated.
There was a problem hiding this comment.
i think these are pretty harmless. they are simple CLI display utilities like the existing chalk and cli-progress packages
There was a problem hiding this comment.
Unfortunately this new dependency is causing an issue for cloudflare workers when attempting to use the mjs (esm modules) file of braintrust. This is because terminal link has a hard dependency on a 10.0 version of supports-color (brought in by supports-hyperlink) that doesn't export a necessary method in their browser build.
I had to temporarily remove the terminal-link dependency here: #1137. It doesn't remove any of the other nice updates from this PR and we will look at bringing the code back probably by porting over some of the code.
We have also made a test to discover this type of issue sooner.
| import type { ExperimentSummary } from "../src/logger"; | ||
| import { BarProgressReporter } from "../src/progress"; | ||
|
|
||
| function createSampleSummary(options: { |
There was a problem hiding this comment.
would be nice if we could move it to an actual test some where some how. i would forget to check the output like this.
i suppose we don't expect this to change much, but would still be nice.
5 participants
