Skip to content

add lingua_passthrough to router metadata#353

Merged
Ken Jiang (knjiang) merged 7 commits into
mainfrom
ken/lingua-passthrough
Jul 13, 2026
Merged

add lingua_passthrough to router metadata#353
Ken Jiang (knjiang) merged 7 commits into
mainfrom
ken/lingua-passthrough

Conversation

@knjiang

Copy link
Copy Markdown
Contributor

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6120782f2d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "Codex (@codex) review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "Codex (@codex) address that feedback".

Comment thread crates/lingua/src/processing/transform.rs

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a635219d18

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "Codex (@codex) review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "Codex (@codex) address that feedback".

false,
false,
),
Err(TransformError::UnsupportedTargetFormat(_)) => (body, None, format, true, true),

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Distinguish unsupported targets from Lingua pass-through

When the target has no Lingua adapter (for example, ProviderFormat::Mistral is not registered in the adapter registry), transform_request returns UnsupportedTargetFormat after detection, not TransformResult::PassThrough. Marking this as lingua_passthrough = true makes observability report a validated Lingua pass-through even when the router is merely falling back to forwarding the original body unchanged, so unsupported-target fallbacks cannot be separated from real same-format pass-throughs.

Useful? React with 👍 / 👎.

@knjiang Ken Jiang (knjiang) merged commit 0709d3c into main Jul 13, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants