fix registered node SSH keepalives - #440
Merged
Merged
Conversation
callen-bot
marked this pull request as ready for review
August 7, 2026 16:47
patelspratik
approved these changes
Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ServerAliveInterval=30andServerAliveCountMax=3to direct SSH connections for registered compute nodesRoot cause
Regular Brev workspaces connect through a generated SSH alias that configures server keepalives. Registered compute nodes connect directly with
runSSHWithPort, bypassing that alias and leavingServerAliveIntervaldisabled by default. Idle connections could therefore be closed by an intermediary or gateway timeout.Impact
Registered-node SSH sessions now send an encrypted keepalive after 30 seconds without server traffic and terminate after three consecutive unanswered keepalives, matching the effective behavior of regular workspace connections.
Testing
go test ./pkg/cmd/...git diff --check