Trumpet for Bosun, Joli, Randy, and Toss#25
Merged
chrisglein merged 6 commits intobrewingcode:masterfrom Sep 15, 2023
Merged
Conversation
Also adjustments to rhythm based on reconciling these: - https://musescore.com/user/27398678/scores/5907496 - https://www.reddit.com/r/netflixwitcher/comments/oggppg/official_sheet_music_of_toss_a_coin_to_your/
brewingcode
reviewed
Sep 15, 2023
| @@ -1,5 +1,6 @@ | |||
| X: 1 | |||
| T: Joli Rouge | |||
| %%vocalfont times 10 | |||
Owner
There was a problem hiding this comment.
I might just reach into abc.js and make the default this font, cause the default is hideous.
Collaborator
Author
There was a problem hiding this comment.
It really is.
Perhaps we have a space for "common ABC props"?
Can preload with this kind of stuff:
[I: MIDI=program 20]
%%titlefont harrington 40
%%vocalfont harrington 10
%%gchordfont harrington 12
%%notecolors 1
%%notelabels 1
Actually, I think that's a good idea. I'll open an issue.
brewingcode
approved these changes
Sep 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Programmatically generated, some of them validated, some will need adjusting for key. But gets it started.
Also fixes to Toss a Coin. It's not quite right in some places with the timing still, but it's better.