ci: run lint on Node.js 22#3714
Open
noritaka1166 wants to merge 1 commit into
Open
Conversation
Owner
|
thanks! i merged yer other PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rationale
The repository uses ESLint 10.2.1, which requires Node.js
^20.19.0 || ^22.13.0 || >=24.The lint job was still running on Node.js 18 and failed before reporting lint
results because
util.styleTextis unavailable in that runtime.Follow-up
Running lint with Node.js 22 exposed an existing TypeScript lint issue:
It is caused by the intentional QueryStream class/namespace declaration merge used to expose
QueryStream.Config.
This will be addressed in a separate follow-up PR.