Consolidate 9 fragmented saint identities missed by the original refactor - #157
Merged
Conversation
…ctor Found while reviewing MCP search_saints output: St Seraphim of Sarov was split across two unlinked Saint rows (repose vs. relics-uncovering), a gap in the original saint-model-refactor's Stage 4 consolidation (its Jaccard threshold missed this pair by a small margin). Scoped further duplicates via five techniques (cross-reference-text scan, occasion- prefix matching, fuzzy edit-distance, exact-name matching, and a targeted day-native-vs-additive scan built from patterns found while manually sampling three months), merging 9 confirmed duplicates and deleting one spurious commemoration entry, each verified against story content and, where ambiguous, left unmerged rather than guessed. Full methodology and per-case reasoning logged in docs/saint-dedup-2026-08.md. 127/127 tests pass. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Hf6j2xXQXywHVh3HAVRxB3
Three merges in the previous commit copied the additive DayCommemoration's full_name verbatim, which conflated the solo saint's identity with a co-commemorated companion (caught in PR review). full_name is meant to be a solo identity descriptor per the original saint-model-refactor's design; companion names belong in story prose, not the identity field. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Hf6j2xXQXywHVh3HAVRxB3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
search_saintsoutput: St Seraphim of Sarov was split across two unlinkedSaintrows (repose vs. relics-uncovering), a gap in the originalsaint-model-refactorproject's Stage 4 consolidation pass (missed the pair by a small margin under its Jaccard threshold).docs/saint-dedup-2026-08.md.Test plan
docker compose run --rm tests— 127/127 passingcalendarium/tests/data/january.json) regenerated and diffed against the live API to confirm only the intended change landedliturgics.Day(...)to confirm no unrelated feast/fast/saint data was disturbed🤖 Generated with Claude Code
https://claude.ai/code/session_01Hf6j2xXQXywHVh3HAVRxB3