Default readings page to LXX2012+WEB; add translation-aware RSS feed - #162
Merged
Merged
Conversation
The readings/landing page now defaults to the modern LXX2012+WEB pairing instead of KJV (remember_translation in calendarium/views.py). The API and RSS feeds are unaffected -- neither calls that function, so translation=None still resolves to kjv via bible.models.DEFAULT_TRANSLATIONS as before. Adds a new RSS feed URL, /api/feed/<tradition>/<cal>/<translation>/, for subscribing to the modern translation specifically. While verifying the new feed, found and fixed a real pre-existing bug: ReadingsFeed.items() never passed fetch_content=True to day.get_readings(), and feed_description.html called reading.pericope.get_passage (a method that re-queries fresh with its own kjv-defaulting arguments) instead of .passage (the cached, correctly-translated attribute) -- so any explicit translation was silently discarded and every feed rendered KJV regardless of what was requested. Had zero test coverage before; added a regression test confirming the two feed URLs actually differ in passage content, not just title/description text. Also adds Day.translation_label as a reusable property, replacing a similarly-hardcoded "(KJV)" heading in the feed description template and simplifying readings_view's own translation label lookup. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Hf6j2xXQXywHVh3HAVRxB3
2 tasks
brianglass
added a commit
that referenced
this pull request
Aug 4, 2026
…ar (#163) about.html's Scriptures section now describes LXX2012+WEB as the readings-page default (with KJV as the alternative, and noting it remains the API/RSS default), matching the change in #162. Also fixes calendar.html's Greek tradition selector, which still used class="beta-note" (removed in an earlier session when that treatment was renamed to .status-badge) -- it's been rendering as unstyled plain text "(beta)" since then. Replaced with the same badge treatment already used on the readings page: tradition-label-with-badge wrapper on both labels, "New" status-badge on Greek. Claude-Session: https://claude.ai/code/session_01Hf6j2xXQXywHVh3HAVRxB3 Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
remember_translation, sotranslation=Nonestill resolves tokjvviabible.models.DEFAULT_TRANSLATIONSexactly as before./api/feed/<tradition>/<cal>/<translation>/(e.g./api/feed/slavic/gregorian/lxx2012-web/), for subscribing to the modern translation specifically. Linked from the feeds documentation page.ReadingsFeed.items()never passedfetch_content=Truetoget_readings(), andfeed_description.htmlcalledreading.pericope.get_passage(a method that re-queries fresh with its ownkjv-defaulting arguments) instead of.passage(the cached, correctly-translated attribute) -- so any explicit translation was silently discarded and every feed rendered KJV regardless of what was requested. This had zero test coverage before.Day.translation_labelas a reusable property, replacing a similarly-hardcoded"(KJV)"heading in the feed description template and simplifyingreadings_view's own translation label lookup.Test plan
docker compose run --rm tests-- 136/136 passing🤖 Generated with Claude Code
https://claude.ai/code/session_01Hf6j2xXQXywHVh3HAVRxB3