Conversation
briansmith
left a comment
There was a problem hiding this comment.
Thanks for taking this on. Please post a new version with these changes and squash them all into one commit with a good commit message. Then I will review the updated version by diffing it with upstream. Also, please use an upstream commit that corresponds to a crates.io release of getrandom.
|
Sorry for getting back to this late - all the points should be addressed, and I'm using the upstream commit corresponding to v0.3.3 on crates.io. Once you've confirmed everything is good, I'll squash everything down to one commit. With With v0.3.4, the |
|
@briansmith Have you had a chance to look at this yet? |
|
@briansmith With #2756, should this PR be closed? |
I hope we'll be able to merge #2756 and avoid having to vendor getrandom, but I won't know for sure until I actually prepare a release. getrandom 0.4 increases the MSRV substantially but it looks like the MSRV increase is good for other reasons anyway. |
|
Closing because #2756 is merged. |
This PR implements the "first PR" outlined here in #2341:
I needed to add
error.rsandutils.rsas well, since theErrorstruct and some utility functions were required by the other files.Currently, running
ringonwasm32-unknown-unknownrequires thegetrandom_backendconfig variable to be set in order forgetrandomto compile properly, but making the ergonomics smoother is outside the scope of PR.