Upgrade from getrandom 0.2 to getrandom 0.4.2, bumping MSRV to 1.85.#2756
Merged
briansmith merged 2 commits intomainfrom Mar 9, 2026
Merged
Upgrade from getrandom 0.2 to getrandom 0.4.2, bumping MSRV to 1.85.#2756briansmith merged 2 commits intomainfrom
briansmith merged 2 commits intomainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2756 +/- ##
==========================================
- Coverage 96.69% 96.68% -0.02%
==========================================
Files 204 204
Lines 20388 20392 +4
Branches 519 519
==========================================
Hits 19715 19715
- Misses 557 561 +4
Partials 116 116 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
briansmith
force-pushed
the
b/getrandom-0.4
branch
3 times, most recently
from
fe86f46 to
dc5efe7
Compare
briansmith
changed the title
Owner
Author
|
Rust 2024 changes will be done in a separate PR. |
Owner
Author
|
The "1.85" MSRV tests in CI need to be updated to use the MSRV-aware resolver, I guess, as otherwise an indirect downstream dependency requires 1.87. |
briansmith
force-pushed
the
b/getrandom-0.4
branch
12 times, most recently
from
affe555 to
5bf9369
Compare
Closed
briansmith
force-pushed
the
b/getrandom-0.4
branch
4 times, most recently
from
8807d93 to
9eb10d5
Compare
Owner
Author
|
I updated this substantially, especially to require getrandom 0.4.2+ and to improve the CI. |
briansmith
force-pushed
the
b/getrandom-0.4
branch
from
9eb10d5 to
004124a
Compare
Owner
Author
|
rust-random/getrandom#824 reduces the MSRV of |
briansmith
force-pushed
the
b/getrandom-0.4
branch
from
004124a to
984c6a9
Compare
briansmith
force-pushed
the
b/getrandom-0.4
branch
2 times, most recently
from
d94f048 to
82740f4
Compare
Owner
Author
|
See also rust-random/getrandom#827 for reducing the dependencies of getrandom (and the MSRV issues) for wasip2/wasip3 targets. |
briansmith
force-pushed
the
b/getrandom-0.4
branch
3 times, most recently
from
68140bd to
f51163d
Compare
briansmith
changed the title
briansmith
force-pushed
the
b/getrandom-0.4
branch
2 times, most recently
from
a04e3b2 to
6412d21
Compare
briansmith
changed the title
briansmith
force-pushed
the
b/getrandom-0.4
branch
from
6412d21 to
e49ab05
Compare
… to 1.85. getrandom 0.4.2 seems to have implemented good enough support with its wasm_js feature to make it usable as an alternative to getrandom 0.2. Rust 1.84 (and getrandom 0.3) dropped support for the old wasm32-wasi target, and won't build for that target, so stop testing it.
briansmith
force-pushed
the
b/getrandom-0.4
branch
from
e49ab05 to
2f04962
Compare
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getrandom 0.4.2 seems to have implemented good enough support with its wasm_js feature to make it usable as an alternative to getrandom 0.2.
Rust 1.84 (and getrandom 0.3) dropped support for the old wasm32-wasi target, and won't build for that target, so stop testing it.