ECDSA: Update for FIPS 186-5.#2863
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2863 +/- ##
==========================================
- Coverage 96.45% 96.44% -0.02%
==========================================
Files 204 204
Lines 20409 20402 -7
Branches 521 521
==========================================
- Hits 19685 19676 -9
- Misses 601 602 +1
- Partials 123 124 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
briansmith
force-pushed
the
b/ecdsa-digest-scalar
branch
2 times, most recently
from
8c0e72f to
9c8b6e2
Compare
Split the computation of the digest from the conversion to a scalar. Simplify the internal `digest_scalar` API by removing its dependency on `Digest`. Add test coverage of P-256 with SHA-384 and P-384 with SHA-256. Remove SHA-1, SHA-224, and SHA-512 test vectors since we don't support these algorithms in ECDSA signatures.
briansmith
force-pushed
the
b/ecdsa-digest-scalar
branch
from
9c8b6e2 to
426ab55
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reorder steps and cite FIPS 186-5 instead of older documentation.