Skip to content

Call PHPUnit methods through self:: instead of $this->#82

Merged
BenMorel merged 1 commit intobrick:masterfrom
tigitz:phpunit-call-type-to-self
Sep 25, 2023
Merged

Call PHPUnit methods through self:: instead of $this->#82
BenMorel merged 1 commit intobrick:masterfrom
tigitz:phpunit-call-type-to-self

Conversation

@tigitz
Copy link
Copy Markdown
Contributor

@tigitz tigitz commented Sep 24, 2023

This is for preference.

Related to #77 (comment)

Note that custom assertX functions are not supported by the fixer, it only take into account PHPUnit ones.

I had to manually replace them to maintain consistency.

@BenMorel BenMorel merged commit 8988982 into brick:master Sep 25, 2023
@BenMorel
Copy link
Copy Markdown
Member

Thank you, @tigitz!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants