fix(ui): status bar survives tall docks; Video undocked; Device Logs docked on old saves - #71
Merged
Merged
Conversation
…docked on old saves Two dogfooding fixes plus one gap-close, all found on macOS: - Status bar disappeared when the emulator accordion expanded: the root window column (title/workbench/status) had no vertical overflow protection, so the macOS emulator panel's tall device lists (20+ iOS simulators) inflated the workbench's min-content height and pushed the status bar off the bottom window edge. Windows never saw it (one Pixel in the list). Fix is the vertical twin of the #59 horizontal one: workbench gets min_height(0) so it shrinks instead of overflowing, the status bar gets flex_shrink(0) so it can never be crushed or pushed out. - The Video demo panel is undocked from the right dock: its console icon duplicated Device Logs' (same DEBUG_CONSOLE glyph under the terminal), and the dock is meant to be the emulator column. Still openable on demand. - The v5 migration also docks Device Logs beside the terminal on orders saved before the panel existed — fresh defaults already had it, but both dev machines' saved orders would never have shown its tab. PANEL_LAYOUT_VERSION -> 5; migration is idempotent and additive-only for customized layouts (arrangements are respected). Tests cover every source shape incl. the v4 dev-box state.
…eLogs docked on old saves)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two dogfooding fixes (found on macOS) + one gap-close for Windows:
Status bar disappearing (macOS)
Expanding the emulator accordion pushed the status bar off the bottom window edge: the root column (title/workbench/status) had no vertical overflow protection, and the macOS panel's device lists (20+ iOS simulators) inflate the workbench's min-content height. Windows never saw it — one Pixel in the list. Fix is the vertical twin of the #59 horizontal fix:
workbenchgetsmin_height(0)(shrinks instead of overflowing), the status bar getsflex_shrink(0)(never crushed/pushed out). Cross-platform safe.Live-verified on macOS: accordion collapsed → expanded, footer stays.
Video panel undocked (user call)
Its
DEBUG_CONSOLEicon duplicated Device Logs' in the pickers, and the right dock is meant to be the emulator column.RightBottomis now empty by default; the demo panel stays openable on demand. Verified live: no Video icon in the right dock.v5 migration (
PANEL_LAYOUT_VERSION = 5)RightBottomon saved orders.