Phase 1: add native NOP request lifecycle - #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Requesttype with prepared, submitted, completed, and teardown-cancelled statesRing.prepare_nop(),Ring.submit(), and non-blocking batchRing.reap()Why
Phase 1 needs request ownership in native structs before real operations can safely move out of CFFI. A NOP is the smallest kernel operation that exercises the complete SQE-to-CQE lifetime without introducing buffer, socket, or cancellation complexity.
The ring owns a reference while a request address is visible to liburing. Reaping the CQE or closing the ring releases that ownership. Ring teardown marks outstanding requests cancelled with
-ECANCELED.Scope
This intentionally does not add blocking waits, asynchronous cancellation, multi-CQE requests, or operation buffers. Those remain separate reviewable milestones.
Validation
ruff check uringloop testsgit diff --check