Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 34 additions & 1 deletion src/uringcore_liburing.c
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ struct UringCoreLiburingRing {
unsigned int features;
unsigned int pending;
unsigned int prepared;
unsigned long long generation;
};

static PyTypeObject UringCoreLiburingRequestType;
Expand Down Expand Up @@ -102,6 +103,7 @@ uringcore_liburing_ring_close_resources(UringCoreLiburingRing *self)
UringCoreLiburingRequest *request;

if (self->initialized) {
self->generation++;
io_uring_queue_exit(&self->ring);
memset(&self->ring, 0, sizeof(self->ring));
self->initialized = 0;
Expand Down Expand Up @@ -300,6 +302,7 @@ uringcore_liburing_ring_init(
}

self->initialized = 1;
self->generation++;
self->sq_entries = params.sq_entries;
self->cq_entries = params.cq_entries;
self->features = params.features;
Expand Down Expand Up @@ -369,15 +372,27 @@ uringcore_liburing_ring_submit(
{
UringCoreLiburingRequest *request;
unsigned int remaining;
unsigned long long generation;
int result;

if (!self->initialized) {
PyErr_SetString(PyExc_RuntimeError, "ring is closed");
return NULL;
}
generation = self->generation;

do {
result = io_uring_submit(&self->ring);
if (result == -EINTR && PyErr_CheckSignals() < 0) {
return NULL;
}
if (result == -EINTR &&
(!self->initialized || self->generation != generation)) {
PyErr_SetString(
PyExc_RuntimeError,
"ring changed while submit was interrupted");
return NULL;
}
} while (result == -EINTR);
if (result < 0) {
errno = -result;
Expand Down Expand Up @@ -417,6 +432,7 @@ uringcore_liburing_ring_reap(
unsigned int max_completions = 64;
PyObject *completed;
unsigned int reaped = 0;
unsigned long long generation;

if (!PyArg_ParseTupleAndKeywords(
args,
Expand Down Expand Up @@ -457,6 +473,7 @@ uringcore_liburing_ring_reap(
PyErr_SetString(PyExc_RuntimeError, "ring is closed");
return NULL;
}
generation = self->generation;

completed = PyList_New(0);
if (completed == NULL) {
Expand All @@ -465,7 +482,23 @@ uringcore_liburing_ring_reap(
while (reaped < max_completions) {
UringCoreLiburingRequest *request;
struct io_uring_cqe *cqe;
int result = io_uring_peek_cqe(&self->ring, &cqe);
int result;

do {
result = io_uring_peek_cqe(&self->ring, &cqe);
if (result == -EINTR && PyErr_CheckSignals() < 0) {
Py_DECREF(completed);
return NULL;
}
if (result == -EINTR &&
(!self->initialized || self->generation != generation)) {
PyErr_SetString(
PyExc_RuntimeError,
"ring changed while completion reaping was interrupted");
Py_DECREF(completed);
return NULL;
}
} while (result == -EINTR);

if (result == -EAGAIN) {
break;
Expand Down
Loading