Skip to content

Wave 0 review feedback: CI hygiene, fork attribution & agent tooling - #2

Merged
leogdion merged 5 commits into
brightdigit-com-260406from
brightdigit-com-260406-feedback-fixes
Jul 22, 2026
Merged

Wave 0 review feedback: CI hygiene, fork attribution & agent tooling#2
leogdion merged 5 commits into
brightdigit-com-260406from
brightdigit-com-260406-feedback-fixes

Conversation

@leogdion

Copy link
Copy Markdown
Member

Applies Wave 0 review feedback to this BrightDigit fork of John Sundell's Files, plus fork-license work required for a Sundell-origin repo.

CI hygiene (.github/workflows/Files.yml)

  • fail-fast: true across all 4 matrix legs (build-ubuntu, build-windows, build-macos-platforms, build-android)
  • Ubuntu coverage: brightdigit/swift-coverage-action fork → sersoft-gmbh/swift-coverage-action@v5; kept id: coverage-files + search-paths: .build; dropped fail-on-empty-output
  • Codecov: removed verbose: true; kept fail_ci_if_error: false, flags, token, files
  • build-macos-platforms: deleted the watchOS ENABLE_WATCHOS gate; added a visionOS leg
  • .spi.yml normalized to swift_version: 6.1
  • .devcontainer/devcontainer.json image → swiftlang/swift:nightly-6.4.x-noble

Sundell fork attribution (preserved, not rewritten)

The MIT License requires keeping John Sundell's original copyright and permission notices verbatim. No source headers and no LICENSE were modified.

  • Added root NOTICE crediting the original work (© 2017 John Sundell) and BrightDigit modifications, both under MIT
  • Added a README fork notice
  • Hardened Scripts/header.sh to skip any file whose top carries an upstream ("Sundell") copyright, so the header tool can never overwrite the original notices

Agent tooling

  • RELEASE_NOTES.md, .claude/agent-notes.md, Memory & Corrections Convention (appended to CLAUDE.md), .claude/skills/

Confirmed: git diff shows zero changes under Sources/, Tests/, or to LICENSE.

🤖 Generated with Claude Code

- fail-fast: true across all matrix legs
- Ubuntu coverage → sersoft-gmbh/swift-coverage-action@v5 (drop fork + fail-on-empty-output)
- Codecov: drop verbose, keep fail_ci_if_error: false
- build-macos-platforms: ungate watchOS, add visionOS leg
- .spi.yml normalized (swift_version 6.1); devcontainer → swiftlang/swift:nightly-6.4.x-noble
- Preserve John Sundell MIT attribution: add NOTICE + README fork note; guard header.sh to never rewrite upstream headers
- Add RELEASE_NOTES.md, .claude/agent-notes.md, Memory & Corrections Convention, .claude/skills/

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jul 21, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 42cc7441-759e-404a-bb1f-5248b75a5334

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch brightdigit-com-260406-feedback-fixes

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Jul 21, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.83%. Comparing base (7ee69ba) to head (8541827).

Additional details and impacted files
@@                   Coverage Diff                   @@
##           brightdigit-com-260406       #2   +/-   ##
=======================================================
  Coverage                   91.83%   91.83%           
=======================================================
  Files                          15       15           
  Lines                         453      453           
=======================================================
  Hits                          416      416           
  Misses                         37       37           
Flag Coverage Δ
macos 91.83% <ø> (ø)
noble 92.93% <ø> (ø)
spm 91.83% <ø> (ø)
swift-6.4 92.93% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

leogdion and others added 4 commits July 21, 2026 21:13
…ll header

- .spi.yml swift_version 6.1 -> 6.4 (matches swift-tools-version:6.4)
- header.sh now emits each file's ORIGINAL upstream Sundell header (verbatim from
  JohnSundell/Files) for any Sundell-attributed file, instead of skipping — so the MIT
  attribution is actively maintained and consistent across the fork. Idempotent.
- Source header comments normalized to the upstream form (comment-only; no code changes).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…er-package branching

header.sh is now byte-identical across Plot/Ink/Files and emits one consistent
upstream John Sundell header (full inline MIT license /** block) for every
Sundell-attributed file — package name + per-file year parameterized, no
if $package branching. Plot/Ink headers expand to the full-license form to match;
comment-only, no code changes. Idempotent.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Replace the dual-template fork header.sh with the two-version model: one
compact John Sundell header — Copyright (c) John Sundell 2019, MIT license see
LICENSE file. Update Scripts/lint.sh to invoke -c "John Sundell" -y 2019 and
re-header all Sources (comment-only; code bodies and LICENSE untouched).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The prior compact-header commit stripped the /// API doc comments that sit
between the license and the first declaration, so swift-format's
AllPublicDeclarationsHaveDocumentation failed in CI (Plot 48, Files 4, Ink 2).
Narrow the awk strip to remove only the leading license block + // lines,
preserving /// docs (and any second /** doc block). Sources re-headered with
docs intact; code bodies and LICENSE untouched.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@leogdion
leogdion merged commit c48be64 into v1.0.0 Jul 22, 2026
10 checks passed
@leogdion
leogdion deleted the brightdigit-com-260406-feedback-fixes branch July 22, 2026 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant