Wave 0 review feedback: CI hygiene, fork attribution & agent tooling - #2
Conversation
- fail-fast: true across all matrix legs - Ubuntu coverage → sersoft-gmbh/swift-coverage-action@v5 (drop fork + fail-on-empty-output) - Codecov: drop verbose, keep fail_ci_if_error: false - build-macos-platforms: ungate watchOS, add visionOS leg - .spi.yml normalized (swift_version 6.1); devcontainer → swiftlang/swift:nightly-6.4.x-noble - Preserve John Sundell MIT attribution: add NOTICE + README fork note; guard header.sh to never rewrite upstream headers - Add RELEASE_NOTES.md, .claude/agent-notes.md, Memory & Corrections Convention, .claude/skills/ Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## brightdigit-com-260406 #2 +/- ##
=======================================================
Coverage 91.83% 91.83%
=======================================================
Files 15 15
Lines 453 453
=======================================================
Hits 416 416
Misses 37 37
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…ll header - .spi.yml swift_version 6.1 -> 6.4 (matches swift-tools-version:6.4) - header.sh now emits each file's ORIGINAL upstream Sundell header (verbatim from JohnSundell/Files) for any Sundell-attributed file, instead of skipping — so the MIT attribution is actively maintained and consistent across the fork. Idempotent. - Source header comments normalized to the upstream form (comment-only; no code changes). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…er-package branching header.sh is now byte-identical across Plot/Ink/Files and emits one consistent upstream John Sundell header (full inline MIT license /** block) for every Sundell-attributed file — package name + per-file year parameterized, no if $package branching. Plot/Ink headers expand to the full-license form to match; comment-only, no code changes. Idempotent. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Replace the dual-template fork header.sh with the two-version model: one compact John Sundell header — Copyright (c) John Sundell 2019, MIT license see LICENSE file. Update Scripts/lint.sh to invoke -c "John Sundell" -y 2019 and re-header all Sources (comment-only; code bodies and LICENSE untouched). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The prior compact-header commit stripped the /// API doc comments that sit between the license and the first declaration, so swift-format's AllPublicDeclarationsHaveDocumentation failed in CI (Plot 48, Files 4, Ink 2). Narrow the awk strip to remove only the leading license block + // lines, preserving /// docs (and any second /** doc block). Sources re-headered with docs intact; code bodies and LICENSE untouched. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Applies Wave 0 review feedback to this BrightDigit fork of John Sundell's Files, plus fork-license work required for a Sundell-origin repo.
CI hygiene (
.github/workflows/Files.yml)fail-fast: trueacross all 4 matrix legs (build-ubuntu, build-windows, build-macos-platforms, build-android)brightdigit/swift-coverage-actionfork →sersoft-gmbh/swift-coverage-action@v5; keptid: coverage-files+search-paths: .build; droppedfail-on-empty-outputverbose: true; keptfail_ci_if_error: false,flags,token,filesENABLE_WATCHOSgate; added a visionOS leg.spi.ymlnormalized toswift_version: 6.1.devcontainer/devcontainer.jsonimage →swiftlang/swift:nightly-6.4.x-nobleSundell fork attribution (preserved, not rewritten)
The MIT License requires keeping John Sundell's original copyright and permission notices verbatim. No source headers and no LICENSE were modified.
NOTICEcrediting the original work (© 2017 John Sundell) and BrightDigit modifications, both under MITScripts/header.shto skip any file whose top carries an upstream ("Sundell") copyright, so the header tool can never overwrite the original noticesAgent tooling
RELEASE_NOTES.md,.claude/agent-notes.md, Memory & Corrections Convention (appended to CLAUDE.md),.claude/skills/Confirmed:
git diffshows zero changes underSources/,Tests/, or toLICENSE.🤖 Generated with Claude Code