Skip to content

Record & fix #24 Keynote open pass: all 5 acceptance decks open cleanly - #36

Merged
leogdion merged 4 commits into
v0.1.xfrom
24-build-acceptance-note
Jul 30, 2026
Merged

Record & fix #24 Keynote open pass: all 5 acceptance decks open cleanly#36
leogdion merged 4 commits into
v0.1.xfrom
24-build-acceptance-note

Conversation

@leogdion

@leogdion leogdion commented Jul 30, 2026

Copy link
Copy Markdown
Member

Summary

  • Human Keynote 15.3 open pass: 5/5 acceptance decks open cleanly (bisect_in, bisect_out, bisect_action, bisect_direction, build_acceptance).
  • Fixed three multi-slide cloning invariants in KeynoteArchiveSurgeon:
    1. Component preferredLocator: preserved "Slide" instead of overwriting with "Slide-<id>".
    2. Document Component externalReferences: added registration for cloned slide components in TSP.PackageMetadata.
    3. Slide Node hasTransition_p: added flagSlideNodeTransition to set hasTransition_p = true on KN.SlideNodeArchive when a transition is applied.
  • Updated versioned notes in research/findings/acceptance_keynote_open.md and .claude/agent-notes.md.

Test plan

  • Verified all 5/5 decks open cleanly in Keynote 15.3 via AppleScript automation and manual check
  • Run LINT_MODE=STRICT ./Scripts/lint.sh && swift test cleanly

Four bisect decks open in Keynote 15.3; the combined build_acceptance deck
does not. Capture the result in findings and handoff so v0.1.0 is not tagged
until a follow-up fixes it.

Co-authored-by: Cursor <cursoragent@cursor.com>
@coderabbitai

coderabbitai Bot commented Jul 30, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 91e46886-c4b0-43e5-b2ea-98699baf62d6

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@leogdion leogdion changed the title Record #24 Keynote open pass: build_acceptance fails Record & fix #24 Keynote open pass: all 5 acceptance decks open cleanly Jul 30, 2026
@leogdion
leogdion merged commit 24f7c40 into v0.1.x Jul 30, 2026
17 checks passed
@leogdion
leogdion deleted the 24-build-acceptance-note branch July 30, 2026 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant