Fix MistDemo Integration static build for Swift 6.4 - #475
Conversation
MistDemo requires tools-version 6.4, so pin the musl build to nightly-6.4.x-noble and the matching 6.4.x-branch Static Linux SDK. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ReviewScope: single-file CI workflow change ( Main concern — the container isn't actually pinnedThe comment claims "Pin nightly container + 6.4.x-branch Static Linux SDK together," but only the SDK half is truly pinned:
That mismatch is a real risk given the PR's own stated goal (build stability): if the container's compiler drifts ahead of the 2026-09-01 SDK snapshot, container: swiftlang/swift:nightly-6.4.x-noble@sha256:<digest>and bumping the digest alongside the SDK snapshot when needed. If "SyndiKit-style" pinning intentionally accepts the floating tag as a tradeoff, it'd be worth a one-line comment saying so explicitly, since the current wording ("pinned... together") reads as a stronger guarantee than what's actually enforced. Minor
Other checks
Overall: reasonable, well-commented unblock for the 6.4 tools-version bump. The one thing I'd want addressed (or explicitly accepted) before merge is the floating-vs-pinned container tag, since it undercuts the stated goal of a fully pinned, reproducible build. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v1.0.0-beta.5 #475 +/- ##
=================================================
- Coverage 86.54% 85.49% -1.05%
=================================================
Files 200 200
Lines 4882 4882
=================================================
- Hits 4225 4174 -51
- Misses 657 708 +51
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
ReviewSmall, well-scoped CI-only change — pins the Nice touch: the Static Linux SDK snapshot is still checksum-pinned ( One thing worth flagging (not a blocker): the updated comment says "Pin nightly container + 6.4.x-branch Static Linux SDK together," but only the SDK side is actually content-pinned. Minor: the PR description's test-plan checkboxes are all unchecked — worth confirming the static build + linkage check + live integration run actually went green before/after merge, since that's the entire point of this change and can't be verified from the diff alone. No functional/library code touched, so no test coverage gap here — this is purely CI infra config. |
Summary
Build static mistdemojob (tools-version 6.4vsswift:6.3.2).MistDemo-Integration.ymltoswiftlang/swift:nightly-6.4.x-nobleplus the matching 6.4.x-branch Static Linux SDK (musl), SyndiKit-style.--swift-sdk x86_64-swift-linux-musl, artifact path, and static linkage verify.Test plan
Build static mistdemosucceeds on this branch (or after merge intov1.0.0-beta.5)not a dynamic executablein Verify static linkageMade with Cursor