Address CodeRabbit findings before v1.0.0 merge#44
Merged
Conversation
Roll back init when AGENTS.md seeding fails, drop uninstall, tighten docs and smoke isolation, and assert --no-push actually creates the worktree. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Return nonzero without rm -rf — a seeding error should not destroy the clone. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
initwhen agent seeding fails so a retry is not blocked by a half-built containerinstall.sh --uninstall(and its README docs) rather than hardening itmkdir -pbefore the curl install, qualifyaddpush wording as default-on~/.gitconfig; assert--no-pushcreates the worktree/branchIntentionally not addressed (with rationale on the review threads after merge):
initpositional (last-wins left as-is)-zfor newline paths (tool-created paths cannot contain them)Test plan
bash -n git-trees install.sh tests/smoke.shshellcheck -s bash git-trees install.sh tests/smoke.shtests/smoke.shMade with Cursor