feat: add mirror transforms OS-20201 (#158) - #159
Merged
t-bashir-bs merged 1 commit intoJul 29, 2026
Conversation
t-bashir-bs
force-pushed
the
tbashir/42-x-y-bs-mirror-transform-OS-20201
branch
from
July 28, 2026 13:08
87ae93c to
2df0316
Compare
caneraltinbasak
approved these changes
Jul 29, 2026
t-bashir-bs
force-pushed
the
tbashir/42-x-y-bs-mirror-transform-OS-20201
branch
from
July 29, 2026 12:02
2df0316 to
a8db160
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Cherry pick of Electron 28 change. There are some changes due to Chromium now having some support for mirror transforms, which has also reduced the amount of code that needs patching. However, they implemented vertical flips for the rot90 and rot270 transforms. To keep the behaviour the same between Electron 28 and 42, there is a conversion in NativeWindowViews::SetWindowTransform and RenderWidgetHostViewAura::RenderWidgetHostViewAura from major::WindowTransformType transform type to Gfx transform type.
Checklist
npm testpassesRelease Notes
Notes: