fix(website): keep sidebar scroll position across navigations#22
Merged
Conversation
The docs rail was wrapped in `View.Show`, which rebuilds its children on every notification from the condition signal. The condition derives from the router location, and `Computed.make` re-notifies on every dependency change even when the computed value is unchanged, so navigating between spec pages tore down and re-created the whole sidebar DOM — and the freshly built <nav> started back at scrollTop 0. Mount the rail once and express "hidden on the landing page" as part of its existing reactive class instead, so navigation only updates the class attribute in place. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LwXbAeJqPcPHSvhRqcPmQA
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The docs rail was wrapped in
started back at scrollTop 0.View.Show, which rebuilds its children on every notification from the condition signal. The condition derives from the router location, andComputed.makere-notifies on every dependency change even when the computed value is unchanged, so navigating between spec pages tore down and re-created the whole sidebar DOM — and the freshly builtMount the rail once and express "hidden on the landing page" as part of its existing reactive class instead, so navigation only updates the class attribute in place.
Claude-Session: https://claude.ai/code/session_01LwXbAeJqPcPHSvhRqcPmQA