Skip to content

CircleCI config update: nodejs install #2239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aweng98 merged 5 commits into from
Sep 25, 2023
Merged

CircleCI config update: nodejs install #2239

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
848134e
update circleci config to download nodejs
aweng98 Sep 25, 2023
56c9896
no sudo
aweng98 Sep 25, 2023
c95040b
no sudo
aweng98 Sep 25, 2023
e883c3c
no sudo
aweng98 Sep 25, 2023
e6898a0
run tests
aweng98 Sep 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -690,12 +690,12 @@ jobs:
# export env from file (created in build-playwright-job)
cat playwright-env/envvars | awk '{print "export " $0}' >> "$BASH_ENV"
source $BASH_ENV
- node/install:
install-yarn: false
node-version: '18.13.0' # LTS version
Comment on lines -693 to -695
Copy link
Contributor Author

@aweng98 aweng98 Sep 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Install custom nodejs version is not working again. It has been very flaky lately. Fallback to default nodejs version provided by CircleCI default.

Copy link
Contributor Author

@aweng98 aweng98 Sep 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Latest failure: https://app.circleci.com/pipelines/github/broadinstitute/ddp-angular/26016/workflows/b87b06cc-58ed-4bcb-a9b7-d4f85d4d6e96/jobs/84566

- run:
name: Check current version of node
command: node -v
- run:
working_directory: *playwright_path
command: npm install --quiet
command: npm ci
- run:
working_directory: *playwright_path
command: npx playwright install --with-deps chromium # Only need Chrome browser
Expand Down