Skip to content

remove genomics operation api for security reasons #713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 19, 2019
Merged

remove genomics operation api for security reasons #713

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5babe3f
remove genomics operation api for security reasons
dvoet Apr 4, 2019
1312b24
removed tests
dvoet Apr 4, 2019
7cfedcf
Merge branch 'develop' into rm_pipeline_op
dvoet Sep 19, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 0 additions & 21 deletions src/main/resources/swagger/api-docs.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4360,27 +4360,6 @@ paths:
500:
description: Rawls Internal Error

/api/workspaces/{workspaceNamespace}/{workspaceName}/genomics/operations/{jobId}:
get:
x-passthrough: true
x-passthrough-target: rawls
tags:
- Workspaces
operationId: getGenomicsOperation
summary: |
Retrieve operations info from Google Genomics API
parameters:
- $ref: '#/parameters/workspaceNamespaceParam'
- $ref: '#/parameters/workspaceNameParam'
- $ref: '#/parameters/jobIdParam'
responses:
200:
description: Operations info
404:
description: jobId not found
500:
description: Rawls Internal Error

/cookie-authed/download/b/{bucket}/o/{object}:
get:
x-passthrough: false
Expand Down
5 changes: 0 additions & 5 deletions src/main/scala/org/broadinstitute/dsde/firecloud/webservice/WorkspaceApiService.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -297,11 +297,6 @@ trait WorkspaceApiService extends HttpService with FireCloudRequestBuilding
}
}
} ~
path("genomics" / "operations" / Segment) { jobId =>
requireUserInfo() { _ =>
passthrough(s"$workspacePath/genomics/operations/$jobId", HttpMethods.GET)
}
} ~
path("tags") {
requireUserInfo() { userInfo =>
get { requestContext =>
Expand Down
20 changes: 0 additions & 20 deletions src/test/scala/org/broadinstitute/dsde/firecloud/service/WorkspaceApiServiceSpec.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,6 @@ class WorkspaceApiServiceSpec extends BaseServiceSpec with WorkspaceApiService w
private final val storageCostEstimatePath = s"$workspacesPath/storageCostEstimate"
private final val tagAutocompletePath = s"$workspacesRoot/tags"
private final val executionEngineVersionPath = "/version/executionEngine"
private final val genomicsOperationsPath = s"$workspacesPath/genomics/operations/$jobId"

private def catalogPath(ns:String=workspace.namespace, name:String=workspace.name) =
workspacesRoot + "/%s/%s/catalog".format(ns, name)
Expand Down Expand Up @@ -406,16 +405,6 @@ class WorkspaceApiServiceSpec extends BaseServiceSpec with WorkspaceApiService w
}
}
}

"Passthrough tests on the /workspaces/%s/%s/genomics/operations/%s path" - {
List(HttpMethods.POST, HttpMethods.PATCH, HttpMethods.PUT, HttpMethods.DELETE) foreach { method =>
s"MethodNotAllowed error is returned for $method" in {
new RequestBuilder(method)(genomicsOperationsPath) ~> dummyUserIdHeaders(dummyUserId) ~> sealRoute(workspaceRoutes) ~> check {
status should equal(MethodNotAllowed)
}
}
}
}
}

"WorkspaceService Passthrough Tests" - {
Expand Down Expand Up @@ -576,15 +565,6 @@ class WorkspaceApiServiceSpec extends BaseServiceSpec with WorkspaceApiService w
}
}
}

"Passthrough tests on the /workspaces/%s/%s/genomics/operations/%s path" - {
"OK status is returned for GET" in {
stubRawlsService(HttpMethods.GET, genomicsOperationsPath, OK)
Get(genomicsOperationsPath) ~> dummyUserIdHeaders(dummyUserId) ~> sealRoute(workspaceRoutes) ~> check {
status should equal (OK)
}
}
}
}

"Workspace Non-passthrough Tests" - {
Expand Down