Added function to subset MT to specified samples and their variants #196
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mike-w-wilson
left a comment
mike-w-wilson
left a comment
There was a problem hiding this comment.
This looks good to me. Just one main thing and then small stuff.
mike-w-wilson
approved these changes
Mar 12, 2020
klaricch
approved these changes
Mar 13, 2020
Contributor
klaricch
left a comment
klaricch
left a comment
There was a problem hiding this comment.
Looks good to me! Are there any downstream functions to recompute things like AC and AN or is that not relevant?
Contributor
Author
|
that's a good question, do we need functions to get those? the sparse MT subsets would require a densify (but dense could just run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.