Skip to content

Conversation

@mike-w-wilson
Copy link
Contributor

This changes min_af, min_callrate, min_inbreeding_coeff_threshold, and min_hardy_weinberg_threshold to Optional args in get_qc_mt. They are already Optional in filter_rows_to_qc. The global annotations are also updated so None can be passed.

Copy link
Contributor

@ch-kr ch-kr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

Copy link
Contributor

@lfrancioli lfrancioli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it!

@mike-w-wilson mike-w-wilson merged commit 21fec5e into master Mar 18, 2020
@mike-w-wilson mike-w-wilson deleted the mw/update_qc_mt branch March 18, 2020 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants