Skip to content

Conversation

@ch-kr
Copy link
Contributor

@ch-kr ch-kr commented Jan 15, 2021

This code updates rep_on_read but won't work right away (_calculate_new_partitions isn't exposed on Tables yet)

@ch-kr ch-kr requested a review from tpoterba January 15, 2021 14:30
@tpoterba
Copy link
Contributor

looks good to me. However, I've actually added a _n_partitions arg to read_table/read_matrix_table in this PR so this can be simplified further!

@ch-kr ch-kr requested a review from jkgoodrich January 21, 2021 16:02
Copy link
Contributor

@jkgoodrich jkgoodrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small change to the change log

@ch-kr ch-kr merged commit d893882 into master Jan 21, 2021
@ch-kr ch-kr deleted the rep_on_read branch January 21, 2021 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants