Skip to content

Conversation

@nawatts
Copy link
Contributor

@nawatts nawatts commented Apr 1, 2021

A few issues fixed here:

  1. Coverage was not recalculated for v2.1.1. That was accounted for in exome resources, but not genome.

  2. Similar to 1, there was no liftover dataset created for v2.1. That was accounted for in exome resources, but not genome.

  3. Using remove to exclude those versions from coverage/liftover resources modified the constant EXOME_RELEASES. Thus, after accessing exome coverage resources, v2.1.1 was not available for any other resource that used that constant. For example:

    from gnomad.resources.grch37 import gnomad
    gnomad.coverage("exomes").ht()
    gnomad.public_release("exomes").ht()
    

    currently throws KeyError: 'default_version 2.1.1 not found in versions dictionary passed to VersionedTableResource.'

    This changes the coverage and liftover functions to create new lists of versions instead of modifying constants.

@nawatts nawatts requested review from a team and gtiao and removed request for a team April 1, 2021 20:24
Copy link
Contributor

@gtiao gtiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- thanks, Nick!

@gtiao gtiao merged commit 28bea6e into master Apr 1, 2021
@gtiao gtiao deleted the coverage-liftover-releases branch April 1, 2021 21:14
@nawatts nawatts mentioned this pull request Apr 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants