Remove module imports from __init__.py files #404
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mike-w-wilson
approved these changes
Aug 18, 2021
Contributor
mike-w-wilson
left a comment
mike-w-wilson
left a comment
There was a problem hiding this comment.
This makes sense and looks good to me!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been trying to figure out why Pylint reports no errors in gnomad_qc despite several v2 scripts importing a function that no longer exists (
gnomad.utils.slack.try_slack). These module imports in__init__.pyfiles seem to confuse Pylint.I don't think they serve a purpose. It looks like I suggested them as an alternative to
from module import *. But I don't think we have any code that relies on them by importing*from one of these packages.