*SCP-2746 Change logger level for cell metadata form validation #147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## development #147 +/- ##
============================================
Coverage 69.00% 69.00%
============================================
Files 22 22
Lines 2678 2678
============================================
Hits 1848 1848
Misses 830 830
Continue to review full report at Codecov.
|
bistline
approved these changes
Sep 18, 2020
eweitz
approved these changes
Sep 18, 2020
devonbush
approved these changes
Sep 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1889670378- We're reporting when cell metadata format is valid with logger.error when it should be reported with logger.info. Because it's reported with logger.error it's being reported in sentry when it shouldn't.