Skip to content

Conversation

@jlchang
Copy link
Contributor

@jlchang jlchang commented Oct 22, 2021

Previously (#211), we relaxed ontology label matching to include synonyms and related synonyms (annotation:has_related_synonym), it seems some ontologies store their synonyms as annotation:has_exact_synonym rather than synonym. This PR addresses the has_exact_synonym wrinkle as the deprecation of diabetes mellitus (disease) to exact synonym in favor of diabetes mellitus also breaks existing test in single_cell_portal repo.

Additionally this PR fixes an error in (#216) where the original method was moved but not removed.

Follow the same testing instructions per #216
BUT test with valid array file from single_cell_portal repo
single_cell_portal/scripts/tests/data/valid_array_v2.1.2.txt
(the similarly named file in the ingest repo was updated in Sept due to the Exact Synonym issue).

This PR support SCP-3631.

@codecov
Copy link

codecov bot commented Oct 22, 2021

Codecov Report

Merging #218 (8b0b2e0) into development (de22060) will decrease coverage by 0.25%.
The diff coverage is 83.33%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development     #218      +/-   ##
===============================================
- Coverage        71.82%   71.57%   -0.26%     
===============================================
  Files               26       26              
  Lines             3099     3092       -7     
===============================================
- Hits              2226     2213      -13     
- Misses             873      879       +6     
Impacted Files Coverage Δ
ingest/ingest_pipeline.py 64.10% <66.66%> (+2.21%) ⬆️
ingest/validation/validate_metadata.py 77.53% <100.00%> (+0.10%) ⬆️
ingest/genomes/utils.py 54.16% <0.00%> (-15.63%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de22060...8b0b2e0. Read the comment docs.

@jlchang jlchang merged commit 51cbd58 into development Oct 25, 2021
@jlchang jlchang deleted the jlc_exact_synonym branch October 25, 2021 11:54
@jlchang
Copy link
Contributor Author

jlchang commented Oct 25, 2021

Marking first build for the PR which failed then succeeded on retry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants