Allow Exact Synonyms in metadata validation (SCP-3631) #218
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously (#211), we relaxed ontology label matching to include synonyms and related synonyms (
annotation:has_related_synonym), it seems some ontologies store their synonyms asannotation:has_exact_synonymrather thansynonym. This PR addresses the has_exact_synonym wrinkle as the deprecation ofdiabetes mellitus (disease)to exact synonym in favor ofdiabetes mellitusalso breaks existing test in single_cell_portal repo.Additionally this PR fixes an error in (#216) where the original method was moved but not removed.
Follow the same testing instructions per #216
BUT test with valid array file from single_cell_portal repo
single_cell_portal/scripts/tests/data/valid_array_v2.1.2.txt
(the similarly named file in the ingest repo was updated in Sept due to the Exact Synonym issue).
This PR support SCP-3631.