Fix conventional single numeric array-based metadata value handing (SCP-4060) #230
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Zendesk 269187 indicated an ingest error about float values that the study owner couldn't understand. This error turns out to be an unhandled exception where ingest did not correctly manage conventional single numeric array-based metadata values.
I've taken Constantine's metadata file and extracted just the head of the file (This avoids the content error that lurks in the file). It can be obtained at gs://fc-2f8ef4c0-b7eb-44b1-96fe-a07f0ea9a982/test_Data/manual_testing/Z269187.txt
To test:
Configure your local instance to use docker image
gcr.io/broad-singlecellportal-staging/scp-ingest-jlc_iterable_float_bugfix:1a92c2bConfirm that ingest of file Z269187.txt succeeds.
This PR resolves SCP-4060