Skip to content

Conversation

@jlchang
Copy link
Contributor

@jlchang jlchang commented Mar 28, 2022

The update of pandas in jlc_make_data_objects caused a cloud build failure because more recent pandas' setup.py invoke import numpy. In a cloud build scenario, numpy is collected but not installed when the pandas build is attempted so the pandas build fails (Older pip builds each package first before installing any packages).
Screen Shot 2022-03-28 at 11 48 50 AM

By updating pip as part of the docker install process, a more sophisticated install solver uses better order of installation to ensure numpy is available before pandas installation is attempted.

Screen Shot 2022-03-28 at 12 48 22 PM

@jlchang jlchang requested review from devonbush and eweitz March 28, 2022 16:57
@codecov
Copy link

codecov bot commented Mar 28, 2022

Codecov Report

Merging #240 (9c87d90) into development (90db079) will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           development     #240   +/-   ##
============================================
  Coverage        71.29%   71.29%           
============================================
  Files               27       27           
  Lines             3518     3518           
============================================
  Hits              2508     2508           
  Misses            1010     1010           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90db079...9c87d90. Read the comment docs.

@jlchang
Copy link
Contributor Author

jlchang commented Mar 28, 2022

Had CI failure for test_genome with http.client.IncompleteRead: IncompleteRead(17437892 bytes read, 33391148 more expected)
Retried CI with success - false positive was due to transient issues with a 3rd party dependency.

@jlchang jlchang merged commit a68ecb5 into development Mar 28, 2022
@jlchang jlchang deleted the jlc_fix_cloud_build branch March 28, 2022 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants