Remove Firestore emulator [SCP-1968] #44
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactors tests to not use the Firestore emulator, following the team's determination that Firestore does not suit our needs. It basically undoes #26.
Like before emulator integration work, tests now intercept calls to methods that load to the database. This decreases coverage and confidence slightly, but makes the tests agnostic to database technology while still being quite robust to changes in Ingest Pipeline's internal implementation.
This satisfies SCP-1968.