Skip to content

Conversation

@skiggety
Copy link
Contributor

clarifications that seemed necessary coming to this fresh

@skiggety skiggety requested review from bistline and eweitz November 14, 2019 18:33
Copy link
Member

@eweitz eweitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice rearrangement and refinement.

@skiggety skiggety requested a review from eweitz November 18, 2019 17:12
@codecov
Copy link

codecov bot commented Nov 18, 2019

Codecov Report

Merging #50 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #50   +/-   ##
=======================================
  Coverage   63.64%   63.64%           
=======================================
  Files          12       12           
  Lines        1180     1180           
=======================================
  Hits          751      751           
  Misses        429      429

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 894a962...570bd77. Read the comment docs.

@skiggety skiggety merged commit f89b31c into master Nov 19, 2019
@skiggety skiggety deleted the sl-git-secrets branch November 19, 2019 15:28
@skiggety skiggety restored the sl-git-secrets branch November 19, 2019 15:29
@bistline bistline deleted the sl-git-secrets branch December 23, 2019 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants