add features you didn't tell me not to add :D#20
Conversation
Add a --status parameter. Fixes: brouberol#18
Also fix a bug with getting tasks twice.
AnotherKamila
changed the title
list
brouberol
left a comment
brouberol
left a comment
There was a problem hiding this comment.
This looks good! I think you should restore fetching the tasks for backup_owner_phid=--owner (pseudocode) though, because it's a useful behavior.
|
Whoops, I did not have enough brain left on that evening '^^ Brain farts should be fixed now, sorry about that. |
brouberol
left a comment
brouberol
left a comment
There was a problem hiding this comment.
Thank you for your first contribution! <3
| ) | ||
| @click.argument("task-ids", type=TASK_ID, nargs=VARIADIC) | ||
| @click.pass_obj | ||
| def set_task_fields( |
There was a problem hiding this comment.
I like where this is going, but I have a small itch. We already have phable status to set a task status. I like your approach better however. I'm going to accept this as-is, and then merge phable status into this command as phable set --status as well as add a deprecation message on phable status itself.
| ) | ||
|
|
||
|
|
||
| class IdsTaskPrinter(TaskPrinter): |
There was a problem hiding this comment.
I can see this being very useful in scripts!
2 participants
Feel free to throw any of it away if you prefer. In particular, the 2nd commit changes behaviour (but I do happen to think that it makes sense :D)