ENG-5629 Fix workflow-use dependency vulnerabilities - #170
Conversation
There was a problem hiding this comment.
Pull request overview
Updates dependency pinning/overrides and lockfiles across the workflows, UI, and browser extension to remediate vulnerabilities tracked in ENG-5629, including a WXT upgrade that required small TypeScript adjustments for updated compiler defaults.
Changes:
- Updated Python constraints/overrides and refreshed
uv.lockto move vulnerable packages onto patched versions. - Updated npm
overrides(and lockfiles) inuiandextensionto pull in patched transitive dependencies. - Upgraded
wxtand adapted extension TypeScript code with type-only imports and additional indexed-access guards.
Reviewed changes
Copilot reviewed 8 out of 11 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| workflows/uv.lock | Refreshes Python lockfile versions and adds/updates constraint & override entries for vulnerable packages. |
| workflows/pyproject.toml | Updates constraint/override dependency pins to enforce patched Python package versions. |
| ui/package.json | Extends npm overrides (and bumps some) to address vulnerable transitive dependencies. |
| ui/package-lock.json | Updates resolved dependency graph to match the new overrides. |
| extension/src/lib/message-bus-types.ts | Switches to type-only import for Workflow (TypeScript compiler-default compatibility). |
| extension/src/entrypoints/sidepanel/context/workflow-provider.tsx | Converts imports to type-only where applicable for updated TS/WXT defaults. |
| extension/src/entrypoints/sidepanel/components/event-viewer.tsx | Converts step imports to type-only to align with updated compiler defaults. |
| extension/src/entrypoints/content.ts | Adds guards for indexed element access under stricter TS settings. |
| extension/src/entrypoints/background.ts | Converts multiple imports to type-only to align with updated compiler defaults. |
| extension/package.json | Upgrades WXT and updates npm overrides to patched transitive versions. |
Files not reviewed (1)
- ui/package-lock.json: Generated file
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2cb428ba6d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
All reported issues were addressed across 11 files
Reply with feedback, questions, or to request a fix.
Fix all with cubic | Re-trigger cubic
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4c14401edf
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Summary
Requires-Distmetadata, with fail-closed resolution for vulnerablebrowser-usereleasesadm-zipandextract-zipdependency pathsVerification
npm audit --package-lock-onlyreports 0 vulnerabilities forextensionanduipip-auditreports no known vulnerabilitiesNotes
browser-usereleases through 0.13.8 still hard-pin vulnerable Click, MCP, and pypdf versions. This PR makes pip reject those releases and blocks publication until an upstream release satisfies the secure wheel metadata. The pending upstream fix is fix(deps): update Click and pypdf security pins browser-use#5560.node-config-menu.tsxTS2322 error that CI explicitly allows; the Vite production bundle succeeds.Linear: ENG-5629