Skip to content

ENG-5629 Fix workflow-use dependency vulnerabilities - #170

Merged
sauravpanda merged 2 commits into
mainfrom
codex/eng-5629-dependency-remediation
Aug 27, 2026
Merged

ENG-5629 Fix workflow-use dependency vulnerabilities#170
sauravpanda merged 2 commits into
mainfrom
codex/eng-5629-dependency-remediation

Conversation

@sauravpanda

@sauravpanda sauravpanda commented Aug 27, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • update npm overrides and Python constraints for the vulnerabilities tracked in ENG-5629
  • publish Python security floors in wheel Requires-Dist metadata, with fail-closed resolution for vulnerable browser-use releases
  • upgrade WXT to remove the vulnerable adm-zip and extract-zip dependency paths
  • run extension CI on Node 22, the supported runtime for WXT 0.21
  • adapt extension TypeScript imports and indexed access checks to WXT 0.21 compiler defaults
  • verify the wheel dependency graph with pip before PyPI publication so uv-only overrides cannot hide conflicts

Verification

  • npm audit --package-lock-only reports 0 vulnerabilities for extension and ui
  • extension lint, TypeScript compile, and production build pass
  • extension TypeScript compile and WXT production build pass explicitly under Node 22.23.2
  • UI lint and Vite production build pass
  • pip-audit reports no known vulnerabilities
  • built wheel metadata contains all patched dependency floors
  • Ruff lint and formatting checks pass
  • focused offline Python tests: 11 passed, 1 skipped

Notes

  • PyPI browser-use releases through 0.13.8 still hard-pin vulnerable Click, MCP, and pypdf versions. This PR makes pip reject those releases and blocks publication until an upstream release satisfies the secure wheel metadata. The pending upstream fix is fix(deps): update Click and pypdf security pins browser-use#5560.
  • The UI full TypeScript build still encounters the pre-existing node-config-menu.tsx TS2322 error that CI explicitly allows; the Vite production bundle succeeds.

Linear: ENG-5629

Copilot AI lite review requested due to automatic review settings August 27, 2026 01:15

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates dependency pinning/overrides and lockfiles across the workflows, UI, and browser extension to remediate vulnerabilities tracked in ENG-5629, including a WXT upgrade that required small TypeScript adjustments for updated compiler defaults.

Changes:

  • Updated Python constraints/overrides and refreshed uv.lock to move vulnerable packages onto patched versions.
  • Updated npm overrides (and lockfiles) in ui and extension to pull in patched transitive dependencies.
  • Upgraded wxt and adapted extension TypeScript code with type-only imports and additional indexed-access guards.

Reviewed changes

Copilot reviewed 8 out of 11 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
workflows/uv.lock Refreshes Python lockfile versions and adds/updates constraint & override entries for vulnerable packages.
workflows/pyproject.toml Updates constraint/override dependency pins to enforce patched Python package versions.
ui/package.json Extends npm overrides (and bumps some) to address vulnerable transitive dependencies.
ui/package-lock.json Updates resolved dependency graph to match the new overrides.
extension/src/lib/message-bus-types.ts Switches to type-only import for Workflow (TypeScript compiler-default compatibility).
extension/src/entrypoints/sidepanel/context/workflow-provider.tsx Converts imports to type-only where applicable for updated TS/WXT defaults.
extension/src/entrypoints/sidepanel/components/event-viewer.tsx Converts step imports to type-only to align with updated compiler defaults.
extension/src/entrypoints/content.ts Adds guards for indexed element access under stricter TS settings.
extension/src/entrypoints/background.ts Converts multiple imports to type-only to align with updated compiler defaults.
extension/package.json Upgrades WXT and updates npm overrides to patched transitive versions.
Files not reviewed (1)
  • ui/package-lock.json: Generated file

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread extension/src/lib/message-bus-types.ts Outdated
Comment thread extension/src/entrypoints/sidepanel/context/workflow-provider.tsx Outdated

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2cb428ba6d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread workflows/pyproject.toml
Comment thread extension/package.json

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 11 files

Reply with feedback, questions, or to request a fix.

Fix all with cubic | Re-trigger cubic

Comment thread workflows/pyproject.toml
Comment thread extension/package.json
Comment thread extension/src/entrypoints/sidepanel/context/workflow-provider.tsx Outdated
Comment thread extension/src/lib/message-bus-types.ts Outdated
Copilot AI review requested due to automatic review settings August 27, 2026 16:42

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 10 out of 13 changed files in this pull request and generated no new comments.

Files not reviewed (1)
  • ui/package-lock.json: Generated file

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4c14401edf

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .github/workflows/publish.yml
@sauravpanda
sauravpanda merged commit 5d2d19f into main Aug 27, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants