fix(cli): omit undefined screenshot options - #2528
Draft
shrey150 wants to merge 1 commit into
Draft
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
undefinedvalues onto the V4 wireThis is the next draft in the CLI migration stack and is based on #2526.
CLI contract changes
screenshotsyntax and result JSONundefinedproperties in the V4 page requestanimations,caret,clip,fullPage,quality, andtypeE2E Test Matrix
BROWSE_DAEMON_DIR=<temp> pnpm --filter browse test:unitpnpm checkabout:blankwith--local, runscreenshot --base64, decode the result, then stopNo Changeset is included because this remains part of the unreleased V4 spike stack.
Summary by cubic
Omit undefined screenshot options so V4 page requests only include flags that are set. Screenshot syntax, output (file/base64), and the 10s timeout remain unchanged.
animations,caret,clip,fullPage,quality, andtypeonly when provided; omit them otherwise.{ timeout: 10_000 }calls and a fully populated request.Written for commit db7b4ca. Summary will update on new commits.