fix(v4): normalize accessibility snapshot Unicode - #2556
Merged
miguelg719 merged 2 commits intoAug 4, 2026
Conversation
|
This was referenced Aug 3, 2026
miguelg719
force-pushed
the
codex/v4-well-formed-snapshots
branch
from
August 3, 2026 05:21
c380e47 to
b807910
Compare
akeimach
approved these changes
Aug 3, 2026
miguelg719
force-pushed
the
codex/v4-well-formed-snapshots
branch
from
August 3, 2026 20:19
b807910 to
d732f2e
Compare
miguelg719
force-pushed
the
codex/v4-well-formed-snapshots
branch
from
August 4, 2026 18:59
1070993 to
b4bb264
Compare
miguelg719
changed the base branch from
codex/v4-operation-timeouts
to
codex/v4-integration-parity
August 4, 2026 19:02
miguelg719
added a commit
that referenced
this pull request
Aug 4, 2026
## Summary - port 23 public-SDK integration specs from main, growing the v4 suite from 5 to 28 files - adapt legacy cases to hermetic v4 fixtures and public APIs - define ten stable local semantic groups with complete, unique test ownership - leave FlowLogger coverage retired because FlowLogger is absent from both v4 implementations ## Scope boundary This PR is mechanical test transfer only. It has no packages/server production changes, generated extension update, or .github/workflows diff from v4-spike. Three transferred specs that expose runtime gaps travel with their standalone fixes: - operation timeouts: #2555 - well-formed snapshot Unicode: #2556 - locator screenshot masks: #2557 Together the stack grows the suite to 31 files. CI orchestration and external-contributor approval policy remain isolated in #2553. The remaining main integration specs are not silently omitted: Agent/streaming/cache cases require the v4 Agent surface; Browserbase/CDP lifecycle, downloads, OOPIF, and connection cases require dedicated browser infrastructure; logger and FlowLogger cases target lifecycle code removed from v4. ## Verification - integration discovery and ownership tests: 12 passed - focused default-page and screenshot-adjacent integration run: 9 passed before extraction - GitHub semantic matrix is the authoritative full-suite validation after this history rewrite ## Review order #2551 → #2555 → #2556 → #2557 → #2553
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repairs malformed Unicode in scoped and merged accessibility snapshots. Includes focused unit coverage and the transferred Unicode integration test.
Stacked directly on #2551. The now-closed #2555 timeout PR is intentionally not part of this stack.