Skip to content

Conversation

@seanmcguire12
Copy link
Member

@seanmcguire12 seanmcguire12 commented Jun 2, 2025

why

  • arxiv was failing because we never updated the code to use the new URL extraction schema
  • ionwave & ionwave_observe were getting blocked by cloudflare

what changed

  • use z.string().url() in arxiv
  • use cloned sites for ionwave & ionwave_observe

@changeset-bot
Copy link

changeset-bot bot commented Jun 2, 2025

⚠️ No Changeset found

Latest commit: 323ee43

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Updates the arxiv evaluation schema to use Zod's URL validation for paper links, but contains potential issues in validation logic.

  • Schema change in evals/tasks/arxiv.ts adds .url() validation and removes .nullable() for paper links
  • Redundant if (paper.link) check in code since schema now guarantees valid URLs
  • Consider removing unnecessary link existence check since Zod schema validation makes it redundant
  • Recommend adding error handling for URL validation failures

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

@seanmcguire12 seanmcguire12 changed the title [evals] fix arxiv [evals] fix arxiv & ionwave Jun 3, 2025
@seanmcguire12 seanmcguire12 merged commit 2ec8e5a into main Jun 3, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants