Skip to content

[evals] fix arxiv & ionwave #792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
seanmcguire12 merged 2 commits into from
Jun 3, 2025
Merged

[evals] fix arxiv & ionwave #792

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6316310
use new link extraction schema
seanmcguire12 Jun 2, 2025
323ee43
use cloned site for ionwave evals
seanmcguire12 Jun 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion evals/tasks/arxiv.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ export const arxiv: EvalFunction = async ({
.array(
z.object({
title: z.string().describe("the title of the paper"),
link: z.string().describe("the link to the paper").nullable(),
link: z.string().url().describe("the link to the paper"),
}),
)
.describe("list of papers"),
Expand Down
6 changes: 4 additions & 2 deletions evals/tasks/ionwave.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,14 +6,16 @@ export const ionwave: EvalFunction = async ({
stagehand,
logger,
}) => {
await stagehand.page.goto("https://elpasotexas.ionwave.net/Login.aspx");
await stagehand.page.goto(
"https://browserbase.github.io/stagehand-eval-sites/sites/ionwave/",
);

await stagehand.page.act({
action: 'Click on "Closed Bids"',
});

const expectedUrl =
"https://elpasotexas.ionwave.net/SourcingEvents.aspx?SourceType=2";
"https://browserbase.github.io/stagehand-eval-sites/sites/ionwave/closed-bids.html";
const currentUrl = stagehand.page.url();

await stagehand.close();
Expand Down
8 changes: 5 additions & 3 deletions evals/tasks/ionwave_observe.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,11 @@ export const ionwave_observe: EvalFunction = async ({
stagehand,
logger,
}) => {
await stagehand.page.goto("https://elpasotexas.ionwave.net/Login.aspx");
await stagehand.page.goto(
"https://browserbase.github.io/stagehand-eval-sites/sites/ionwave/",
);

const observations = await stagehand.page.observe({ onlyVisible: true });
const observations = await stagehand.page.observe();

if (observations.length === 0) {
await stagehand.close();
Expand All @@ -21,7 +23,7 @@ export const ionwave_observe: EvalFunction = async ({
};
}

const expectedLocator = `div.rowLinks:nth-child(27) > div:nth-child(1) > a:nth-child(1)`;
const expectedLocator = `#Form1 > div:nth-child(5) > div:nth-child(1) > a`;

const expectedResult = await stagehand.page
.locator(expectedLocator)
Expand Down