chore: refresh TypeScript CDP and retire hidden surfaces

[Nikhil (shadowfax92)]

Summary

• regenerate @browseros/cdp-protocol from the exact 58-domain combined Chromium protocol, with validated input provenance and deterministic formatting
• keep compatibility-only hidden members in generated wire definitions while projecting them out of BrowserOS-owned page state
• retire hidden tab/window controls across TypeScript core, scheduled-task handling, MCP schemas, structured results, descriptions, and tests

Design

The generated CDP package remains the complete mixed-version wire contract. Browser core now explicitly projects generated TabInfo into the narrower owned PageInfo, so compatibility fields cannot leak into application or MCP payloads. Scheduled runs use managed background pages, while normal/background and explicit-window creation semantics remain intact.

Test plan

• CDP_PROTOCOL_JSON=/Users/shadowfax/code/chromium-checkouts/chromium-1/src/out/Default_arm64/gen/third_party/blink/public/devtools_protocol/protocol.json bun run gen:cdp
• bun run check
• bun run test
• bun run test:main
• targeted browser-core, browser-mcp, server, parser, schema, and structured-contract tests/typechecks
• ownership scans and git diff --check

[Nikhil (shadowfax92)]

Claude (@claude) review

[Nikhil (shadowfax92)]

Greptile (@greptileai) review

[claude]

Claude finished Nikhil (@shadowfax92)'s task in 2m 51s —— View job

---

Claude's Review

I reviewed the diff against origin/main for this PR, focusing on the CDP codegen refresh and the hidden-tab/window retirement across the TypeScript packages.

Tasks

• Gather context (repo guidelines, diff)
• Review CDP codegen changes
• Review browser-core / pages.ts / windows.ts changes
• Review browser-mcp changes (tabs.ts, windows.ts, tests)
• Review server changes (chat-service, prompt, session-store)
• Attempt bun run check / bun run test (blocked — see note below)
• Post review feedback

---

Overall

This is a clean, well-scoped refactor. The projection pattern in pages.ts (pageInfoFromProtocol) is a good way to keep the generated wire contract's compatibility-only fields (isHidden, hidden, includeHidden, showTab, setWindowVisibility) from leaking into PageInfo/MCP results, while the Rust-side browseros_protocol.json (crates/browseros-cdp/...) still defines those fields as optional — so wire backward-compatibility is preserved even though the TS core no longer emits/consumes them. The hidden-tab/window removal is consistently threaded through browser-core, browser-mcp tool schemas, server session/chat-service code, and tests — I didn't find dangling references to hiddenPageId, isHidden, showTab, or setWindowVisibility left behind on the TS side.

Findings

1. packages/browseros-agent/packages/browser-core/src/core/pages.ts:381-402 — pageInfoFromProtocol no longer falls back to the previous index/groupId when the protocol response omits them.
   Previously list()/updateFromTab() used {...existing, ...tab} (or Object.assign), so if a TabInfo response ever omitted the optional index/groupId keys, the previously cached values were preserved. The old in-code comment only called out windowId as needing this treatment ("CDP omits windowId for hidden tabs — preserve the cached value"), and the new helper only preserves windowId/url via fallback. If index/groupId are ever transiently absent from a Browser.getTabs/getTabInfo response (e.g., a tab not currently in a tab-strip/group), the new code will drop the field to undefined instead of keeping the last known value, whereas the old code wouldn't have. Given the domain comment suggests only windowId was known to be intermittently omitted, this is likely fine, but worth double-checking against real CDP behavior before merge since it's a silent behavior change.

2. packages/browseros-agent/apps/claw-app/tsconfig.json:5-7 — removal of "paths": {"@/*": ["./*"]} looks unrelated to this PR's stated scope (CDP protocol refresh / hidden-surface retirement). I confirmed there are no @/... imports left in apps/claw-app, so it's not a build break, but it's worth a sentence in the PR description (or a separate commit) since it's scope creep from an otherwise focused refactor — it landed via the "repair TypeScript verification baselines" commit rather than the hidden-retirement work.

3. Minor: protocol-api-emitter.ts switched domain sorting from localeCompare to manual </> comparison — reasonable for deterministic, locale-independent codegen output (matches the PR's "deterministic formatting" goal), just flagging so it's confirmed intentional rather than incidental.

Test coverage

The new/updated tests (browser.test.ts, pages.test.ts, protocol-parser.test.ts) look meaningful — they assert on actual call arguments (e.g., getTabs() called with no args, createWindow() called with no hidden option) rather than just re-asserting mocked returns, and the new protocol-parser.test.ts covers malformed/incomplete/duplicate-domain JSON well.

Note on verification

I was not able to execute bun run check / bun run test / bun run test:main in this sandbox (shell command execution beyond basic read-only git commands required approval that wasn't available in this run). The PR description states these were run locally with a passing result; I'd recommend confirming CI is green before merge rather than relying solely on this review. If you'd like me to attempt running the suite, you can update the --allowedTools config to permit Bash(bun *).

[greptile-apps]

Greptile Summary

Refreshes the generated TypeScript CDP contract and removes hidden tab/window surfaces.

• Regenerates the complete 58-domain CDP package with stricter input validation and deterministic formatting.
• Projects generated tab data into BrowserOS-owned page state so compatibility-only fields do not leak into structured results.
• Replaces scheduled hidden pages with managed background pages and removes hidden tab/window controls from core, MCP schemas, prompts, and tests.

Confidence Score: 5/5

The PR appears safe to merge, with no concrete changed-code defect identified.

The generated protocol refresh, owned page-state projection, scheduled background-page lifecycle, and reduced MCP schemas are coordinated across implementation and contract tests without an established broken caller or runtime invariant.

Important Files Changed

Filename	Overview
packages/browseros-agent/scripts/codegen/cdp-protocol.ts	Adds source provenance, validation, hashing, deterministic formatting, and regenerated package exports.
packages/browseros-agent/scripts/codegen/lib/protocol-parser.ts	Changes parsing to accept source text and reject malformed versions, domains, and duplicate domain names.
packages/browseros-agent/packages/browser-core/src/core/pages.ts	Removes hidden-page handling and explicitly projects generated TabInfo values into the narrower PageInfo model.
packages/browseros-agent/packages/browser-core/src/browser.ts	Removes hidden page creation and routes new pages to an existing visible window or a newly created normal window.
packages/browseros-agent/apps/server/src/api/services/chat-service.ts	Migrates scheduled-task lifecycle tracking from hidden pages to managed background pages.
packages/browseros-agent/packages/browser-mcp/src/tools/tabs.ts	Removes the hidden tab option while retaining background tab creation.
packages/browseros-agent/packages/browser-mcp/src/tools/windows.ts	Removes hidden-window creation and window visibility mutation from the MCP contract.
packages/browseros-agent/packages/cdp-protocol/package.json	Adds exports for the newly generated CrashReportContext and WebMCP domains.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart LR
  Chromium["Combined Chromium CDP protocol"] --> Generator["Validated deterministic generator"]
  Generator --> CDP["@browseros/cdp-protocol"]
  CDP --> Core["browser-core projection"]
  Core --> PageInfo["Owned PageInfo without compatibility-only fields"]
  PageInfo --> MCP["browser-mcp structured results"]
  Server["Scheduled task"] --> Background["Managed background page"]
  Background --> Core

Loading

_{Reviews (1): Last reviewed commit: "chore: merge latest main" | Re-trigger Greptile}

[greptile-apps]

Greptile Summary

Refreshes the generated TypeScript CDP contract and removes hidden browser surfaces.

• Regenerates the 58-domain CDP package with source validation, hashing, deterministic ordering, formatting, and new domain exports.
• Projects generated protocol tab data into the narrower BrowserOS-owned PageInfo shape.
• Replaces scheduled hidden pages with managed background pages and removes hidden tab/window controls from browser core, MCP schemas, prompts, structured results, and tests.
• Updates TypeScript and release-test baselines for the refreshed toolchain and contracts.

Confidence Score: 5/5

The PR appears safe to merge, with no concrete blocking or independently actionable issues identified in the changed behavior.

The generated protocol exports remain coordinated, BrowserOS-owned page state explicitly excludes compatibility-only fields, and hidden-surface removal is consistently propagated through core, server, MCP contracts, prompts, and tests.

Important Files Changed

Filename	Overview
packages/browseros-agent/scripts/codegen/cdp-protocol.ts	Adds explicit protocol-source validation, SHA-256 provenance logging, deterministic regeneration, and formatting.
packages/browseros-agent/scripts/codegen/lib/protocol-parser.ts	Changes parsing to accept source text and validates the top-level version and unique domain structure.
packages/browseros-agent/packages/browser-core/src/core/pages.ts	Removes hidden-page management and explicitly projects generated TabInfo values into owned PageInfo state.
packages/browseros-agent/packages/browser-core/src/browser.ts	Narrows page-creation options and resolves new pages into an existing visible window or a newly created normal window.
packages/browseros-agent/packages/browser-mcp/src/tools/tabs.ts	Removes hidden-tab input while retaining list, active, background creation, and close behavior.
packages/browseros-agent/packages/browser-mcp/src/tools/windows.ts	Retires hidden-window creation and visibility mutation from the MCP window tool.
packages/browseros-agent/apps/server/src/api/services/chat-service.ts	Migrates scheduled-task lifecycle tracking from hidden pages to managed background pages.
packages/browseros-agent/packages/cdp-protocol/package.json	Adds exports for newly generated CrashReportContext and WebMCP domains and APIs.
packages/browseros-agent/apps/claw-app/tsconfig.json	Removes the local path-alias override while continuing to extend WXT's generated TypeScript configuration.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart LR
  Chromium["Chromium combined CDP protocol"] --> Generator["Validated deterministic generator"]
  Generator --> Wire["@browseros/cdp-protocol<br/>complete wire contract"]
  Wire --> Projection["browser-core TabInfo projection"]
  Projection --> PageInfo["BrowserOS PageInfo<br/>hidden compatibility fields omitted"]
  PageInfo --> MCP["Browser MCP structured results"]
  Scheduler["Scheduled task"] --> Background["Managed background page"]
  Background --> Projection

Loading

_{Reviews (2): Last reviewed commit: "chore: merge latest main" | Re-trigger Greptile}

[github-actions]

✅ Tests passed — 1694/1698

Suite	Passed	Failed	Skipped
✅ agent	350/350	0	0
✅ build	34/34	0	0
✅ claw-app	215/215	0	0
⚠️ claw-mcp	0/0	0	0
⚠️ claw-onboard	0/0	0	0
⚠️ claw-server-rust-quality	0/0	0	0
⚠️ claw-server-rust	0/0	0	0
✅ server-agent	313/313	0	0
✅ server-api	171/171	0	0
✅ server-browser	10/10	0	0
✅ server-integration	10/10	0	0
✅ server-lib	299/300	0	1
✅ server-root	38/41	0	3
✅ server-tools	254/254	0	0

View workflow run