ci(v8): port the changeset-from-pr auto-generator to the v8 branch - #113
Merged
Conversation
For pull_request events GitHub runs the workflow from the PR's BASE branch, so the auto-changeset generator (added to main in #71) never ran for v8-base PRs — they merged with no changeset (e.g. #87 -> had to backfill via #111). Porting the same workflow to v8 makes v8-base PRs get .changeset/pr-<n>.md auto-generated from their Release section, exactly like main. Byte-for-byte identical to main's changeset-from-pr.yml (fully branch-agnostic: package @wdio/browserstack-service, .changeset/pr-<n>.md at repo root, parses the ## Release section). v8 already has the ready-for-review gate that makes that section mandatory, so only the generator was missing. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
AakashHotchandani
requested review from
anish353 and
xxshubhamxx
and removed request for
a team
July 29, 2026 12:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
v8-base PRs weren't getting changesets auto-generated, so they merged with none and no Version Packages PR opened (e.g. #87 → backfilled manually in #111).
Root cause: for
pull_requestevents, GitHub runs the workflow from the PR's base branch. The generator (changeset-from-pr.yml) was added tomainin #71, so it only ever ran formain-base PRs — never forv8-base ones.What
Adds
.github/workflows/changeset-from-pr.ymltov8, byte-for-byte identical tomain's. The workflow is fully branch-agnostic:@wdio/browserstack-service(same on v8),.changeset/pr-<number>.mdat the repo root (correct on v8),## Releasesection — v8 uses the same PR template (SDK-6983: rescue SDK-log upload on signal termination (v8 port of #86) #87 proved it), and v8 already has theready-for-reviewgate that makes that section mandatory.So only the generator was missing. No layout/main-specific assumptions to adapt.
Effect
After merge, any open/edited/synchronized/(re)labeled v8-base PR gets its changeset committed to the PR branch automatically — same behavior as
main. Skips forks,changeset-release/*, andskip-changeset-labelled PRs. Idempotent (its own push settles in one no-op pass).No double-run risk with main's copy: a PR only runs its base branch's workflow, so
main-base PRs use main's copy andv8-base PRs use this one.