Skip to content

ci: mirror ready-for-review label + SDK PR review gate workflows onto v8#62

Merged
xxshubhamxx merged 2 commits into
v8from
ci/port-pr-review-workflows-to-v8
Jul 19, 2026
Merged

ci: mirror ready-for-review label + SDK PR review gate workflows onto v8#62
xxshubhamxx merged 2 commits into
v8from
ci/port-pr-review-workflows-to-v8

Conversation

@xxshubhamxx

@xxshubhamxx xxshubhamxx commented Jul 19, 2026

Copy link
Copy Markdown
Collaborator

What is this about?

Follow-up to #57. Those PR-hygiene files were ported to main only, so PRs targeting the v8 release line (e.g. #59) never triggered the gates: GitHub evaluates pull_request workflows from the base branch / merge-commit copy, and v8 had none.

This mirrors all three files onto v8, byte-identical to main (same blob SHAs), so the two lines stay in sync:

  • .github/PULL_REQUEST_TEMPLATE.md (blob 4a2540d)
  • .github/workflows/ready-for-review-label.yml (blob 7166b09)
  • .github/workflows/sdk-pr-review-gate.yml (blob adb7570)

The template is included so v8 PRs get the ## Release section auto-populated regardless of how GitHub resolves the template branch — the ready-for-review gate reads that section, so without it a v8 PR would fail the gate on "missing ## Release section."

Fork PRs (e.g. #55, #59): this repo accepts PRs from forks, where pull_request grants a read-only GITHUB_TOKEN. The gate still fails closed correctly (the require-label step is a plain exit 1), but label-removal and warning-comment actions will silently no-op on fork PRs. Making those work would require pull_request_target — deliberately not done here to keep the port faithful to browserstack-ruby-sdk and avoid running privileged in the base context.

Related Jira task/s

Release (mandatory for every PR — required for the ready-for-review label)

Version bump: (required — tick exactly one)

  • minor (backwards-compatible feature)
  • patch (bug fix or other small change)

Release notes type: (optional)

  • Other Improvement

Release notes (customer-facing): (optional but encouraged)

Release notes (internal): (required — engineer-facing; what actually changed / why)

Checklist

  • Ready to review
  • Has it been tested locally?

PR Validations

Run Tests: Comment RUN_TESTS to trigger sanity tests.

🤖 Generated with Claude Code

These gates were ported to main in #57 but v8 PRs (the active release line) were left ungated because pull_request triggers evaluate the base-branch/merge-commit copy. Mirror both workflows onto v8, byte-identical to main.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@xxshubhamxx
xxshubhamxx requested a review from a team as a code owner July 19, 2026 09:23
@xxshubhamxx
xxshubhamxx requested review from pranay-v29 and rounak610 and removed request for a team July 19, 2026 09:23
Ensures v8 PRs get the ## Release section auto-populated (the ready-for-review gate reads it), independent of how GitHub resolves the template branch. Byte-identical to main.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@xxshubhamxx
xxshubhamxx merged commit dccf9e2 into v8 Jul 19, 2026
3 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant